opt: more linter (#1765)

* opt: more linter

* fix [skip ci]

Signed-off-by: bggRGjQaUbCoE <githubaccount56556@proton.me>

---------

Co-authored-by: bggRGjQaUbCoE <githubaccount56556@proton.me>

lib/plugin/pl_player/controller.dart

@@ -229,9 +229,9 @@ class PlPlayerController {
 
   Offset initialFocalPoint = Offset.zero;
 
-  Future<void> exitDesktopPip() async {
+  Future<void> exitDesktopPip() {
     isDesktopPip = false;
-    await Future.wait([
+    return Future.wait([
       windowManager.setTitleBarStyle(TitleBarStyle.normal),
       windowManager.setMinimumSize(const Size(400, 700)),
       windowManager.setBounds(_lastWindowBounds),
@@ -1009,8 +1009,9 @@ class PlPlayerController {
 
   /// 播放事件监听
   void startListeners() {
+    final controllerStream = videoPlayerController!.stream;
     subscriptions = {
-      videoPlayerController!.stream.playing.listen((event) {
+      controllerStream.playing.listen((event) {
         WakelockPlus.toggle(enable: event);
         if (event) {
           if (_shouldSetPip) {
@@ -1039,7 +1040,7 @@ class PlPlayerController {
           makeHeartBeat(positionSeconds.value, type: HeartBeatType.status);
         }
       }),
-      videoPlayerController!.stream.completed.listen((event) {
+      controllerStream.completed.listen((event) {
         if (event) {
           playerStatus.value = PlayerStatus.completed;
 
@@ -1052,7 +1053,7 @@ class PlPlayerController {
         }
         makeHeartBeat(positionSeconds.value, type: HeartBeatType.completed);
       }),
-      videoPlayerController!.stream.position.listen((event) {
+      controllerStream.position.listen((event) {
         position.value = event;
         updatePositionSecond();
         if (!isSliderMoving.value) {
@@ -1066,14 +1067,14 @@ class PlPlayerController {
         }
         makeHeartBeat(event.inSeconds);
       }),
-      videoPlayerController!.stream.duration.listen((Duration event) {
+      controllerStream.duration.listen((Duration event) {
         duration.value = event;
       }),
-      videoPlayerController!.stream.buffer.listen((Duration event) {
+      controllerStream.buffer.listen((Duration event) {
         buffered.value = event;
         updateBufferedSecond();
       }),
-      videoPlayerController!.stream.buffering.listen((bool event) {
+      controllerStream.buffering.listen((bool event) {
         isBuffering.value = event;
         videoPlayerServiceHandler?.onStatusChange(
           playerStatus.value,
@@ -1082,14 +1083,14 @@ class PlPlayerController {
         );
       }),
       if (kDebugMode)
-        videoPlayerController!.stream.log.listen(((PlayerLog log) {
+        controllerStream.log.listen(((PlayerLog log) {
           if (log.level == 'error' || log.level == 'fatal') {
             Utils.reportError('${log.prefix}: ${log.text}', null);
           } else {
             debugPrint(log.toString());
           }
         })),
-      videoPlayerController!.stream.error.listen((String event) {
+      controllerStream.error.listen((String event) {
         if (isFileSource && event.startsWith("Failed to open file")) {
           return;
         }
@@ -1107,7 +1108,7 @@ class PlPlayerController {
             //tcp: ffurl_read returned 0xffffff99
             event.startsWith('tcp: ffurl_read returned ')) {
           EasyThrottle.throttle(
-            'videoPlayerController!.stream.error.listen',
+            'controllerStream.error.listen',
             const Duration(milliseconds: 10000),
             () {
               Future.delayed(const Duration(milliseconds: 3000), () async {
@@ -1141,7 +1142,7 @@ class PlPlayerController {
           SmartDialog.showToast('视频加载错误, $event');
         }
       }),
-      // videoPlayerController!.stream.volume.listen((event) {
+      // controllerStream.volume.listen((event) {
       //   if (!mute.value && _volumeBeforeMute != event) {
       //     _volumeBeforeMute = event / 100;
       //   }
@@ -1167,8 +1168,8 @@ class PlPlayerController {
   }
 
   /// 移除事件监听
-  Future<void> removeListeners() async {
-    await Future.wait(subscriptions.map((e) => e.cancel()));
+  Future<void> removeListeners() {
+    return Future.wait(subscriptions.map((e) => e.cancel()));
   }
 
   /// 跳转至指定位置
@@ -1405,7 +1406,7 @@ class PlPlayerController {
   }
 
   /// 设置后台播放
-  Future<void> setBackgroundPlay(bool val) async {
+  void setBackgroundPlay(bool val) {
     videoPlayerServiceHandler?.enableBackgroundPlay = val;
     if (!tempPlayerConf) {
       setting.put(SettingBoxKey.enableBackgroundPlay, val);

lib/plugin/pl_player/view.dart

@@ -655,7 +655,7 @@ class _PLVideoPlayerState extends State<PLVideoPlayer>
 
       /// 字幕
       BottomControlType.subtitle => Obx(
-        () => videoDetailController.subtitles.isEmpty == true
+        () => videoDetailController.subtitles.isEmpty
             ? const SizedBox.shrink()
             : PopupMenuButton<int>(
                 tooltip: '字幕',