tweaks (#1187)

* opt: marquee

* fix: bangumi seek

* opt: post panel

* opt: remove deprecated code

* opt: singleton dynController

* fix: music scheme

* feat: MemberVideo jump keep position

* tweak

lib/pages/music/controller.dart

@@ -20,6 +20,9 @@ class MusicDetailController extends CommonDynController {
 
   bool get showDynActionBar => Pref.showDynActionBar;
 
+  String get shareUrl =>
+      'https://music.bilibili.com/h5/music-detail?music_id=${musicId}';
+
   @override
   void onInit() {
     super.onInit();

lib/pages/music/video/controller.dart

@@ -5,6 +5,8 @@ import 'package:PiliPlus/models_new/music/bgm_recommend_list.dart';
 import 'package:PiliPlus/pages/common/common_list_controller.dart';
 import 'package:get/get.dart';
 
+typedef MusicRecommendArgs = ({String id, MusicDetail item});
+
 class MusicRecommendController
     extends CommonListController<List<BgmRecommend>?, BgmRecommend> {
   late final String musicId;
@@ -13,9 +15,9 @@ class MusicRecommendController
   @override
   void onInit() {
     super.onInit();
-    final Map<String, dynamic> args = Get.arguments;
-    musicId = args['id'];
-    musicDetail = args['detail'];
+    final MusicRecommendArgs args = Get.arguments;
+    musicId = args.id;
+    musicDetail = args.item;
     queryData();
   }
 

lib/pages/music/video/view.dart

@@ -6,8 +6,8 @@ import 'package:PiliPlus/models/common/image_type.dart';
 import 'package:PiliPlus/models_new/music/bgm_recommend_list.dart';
 import 'package:PiliPlus/pages/music/video/controller.dart';
 import 'package:PiliPlus/pages/music/widget/music_video_card_h.dart';
+import 'package:PiliPlus/utils/extension.dart';
 import 'package:PiliPlus/utils/grid.dart';
-import 'package:PiliPlus/utils/utils.dart';
 import 'package:flutter/material.dart';
 import 'package:get/get.dart';
 
@@ -20,9 +20,9 @@ class MusicRecommandPage extends StatefulWidget {
 
 class _MusicRecommandPageState extends State<MusicRecommandPage>
     with GridMixin {
-  late final _controller = Get.put(
-    MusicRecommendController(),
-    tag: Utils.generateRandomString(8),
+  late final MusicRecommendController _controller = Get.putOrFind(
+    MusicRecommendController.new,
+    tag: (Get.arguments as MusicRecommendArgs).id,
   );
 
   @override
@@ -34,7 +34,6 @@ class _MusicRecommandPageState extends State<MusicRecommandPage>
       child: refreshIndicator(
         onRefresh: _controller.onRefresh,
         child: CustomScrollView(
-          controller: _controller.scrollController,
           physics: const AlwaysScrollableScrollPhysics(),
           slivers: [
             _buildAppBar(theme, padding),

lib/pages/music/view.dart

@@ -36,9 +36,9 @@ class MusicDetailPage extends StatefulWidget {
 
 class _MusicDetailPageState extends CommonDynPageState<MusicDetailPage> {
   @override
-  final MusicDetailController controller = Get.put(
-    MusicDetailController(),
-    tag: Utils.generateRandomString(8),
+  late final MusicDetailController controller = Get.putOrFind(
+    MusicDetailController.new,
+    tag: Get.parameters['musicId']!,
   );
 
   @override
@@ -110,7 +110,7 @@ class _MusicDetailPageState extends CommonDynPageState<MusicDetailPage> {
           child = Padding(
             padding: EdgeInsets.symmetric(horizontal: padding),
             child: CustomScrollView(
-              controller: controller.scrollController,
+              controller: scrollController,
               physics: const AlwaysScrollableScrollPhysics(),
               slivers: [
                 SliverToBoxAdapter(
@@ -136,7 +136,7 @@ class _MusicDetailPageState extends CommonDynPageState<MusicDetailPage> {
               Expanded(
                 flex: flex,
                 child: CustomScrollView(
-                  controller: controller.scrollController,
+                  controller: scrollController,
                   physics: const AlwaysScrollableScrollPhysics(),
                   slivers: [
                     SliverPadding(
@@ -235,7 +235,7 @@ class _MusicDetailPageState extends CommonDynPageState<MusicDetailPage> {
       right: 0,
       bottom: 0,
       child: SlideTransition(
-        position: controller.fabAnim,
+        position: fabAnim,
         child: controller.showDynActionBar
             ? Column(
                 mainAxisSize: MainAxisSize.min,
@@ -288,9 +288,8 @@ class _MusicDetailPageState extends CommonDynPageState<MusicDetailPage> {
                           child: textIconButton(
                             icon: CustomIcon.share_node,
                             text: '分享',
-                            onPressed: () => Utils.shareText(
-                              'https://music.bilibili.com/h5/music-detail?music_id=${controller.musicId}',
-                            ),
+                            onPressed: () =>
+                                Utils.shareText(controller.shareUrl),
                           ),
                         ),
                         Expanded(
@@ -565,7 +564,7 @@ class _MusicDetailPageState extends CommonDynPageState<MusicDetailPage> {
                     theme,
                     () => Get.to(
                       const MusicRecommandPage(),
-                      arguments: {'id': controller.musicId, 'detail': item},
+                      arguments: (id: controller.musicId, item: item),
                     ),
                   ),
                 ],